From 4e2f6d7d8f870f834079ce010eb2049d61bb5576 Mon Sep 17 00:00:00 2001 From: Achim Gratz Date: Sun, 6 Jan 2013 18:28:06 +0100 Subject: [PATCH 1/3] Compatibility: Use org-no-warnings MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * contrib/lisp/org-e-odt.el (org-e-odt-htmlfontify-string): Use compatibility alias `org-no-warnings´. --- contrib/lisp/org-e-odt.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/lisp/org-e-odt.el b/contrib/lisp/org-e-odt.el index 346b02926..5953cc672 100644 --- a/contrib/lisp/org-e-odt.el +++ b/contrib/lisp/org-e-odt.el @@ -2886,7 +2886,7 @@ and prefix with \"OrgSrc\". For example, (lambda (style text-block text-id text-begins-block-p) (insert (format "" style)))) (hfy-end-span-handler (lambda nil (insert "")))) - (with-no-warnings (htmlfontify-string line)))) + (org-no-warnings (htmlfontify-string line)))) (defun org-e-odt-do-format-code (code &optional lang refs retain-labels num-start) From d524e7d6112cda2b53e3e0822609fa81b2dd6ee9 Mon Sep 17 00:00:00 2001 From: Achim Gratz Date: Sun, 6 Jan 2013 17:48:39 +0100 Subject: [PATCH 2/3] Compatibility: Define face alias mode-line for XEmacs * lisp/org-faces.el: Define face alias mode-line for XEmacs (it's called modeline there). --- lisp/org-faces.el | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lisp/org-faces.el b/lisp/org-faces.el index 80e81349f..606db0814 100644 --- a/lisp/org-faces.el +++ b/lisp/org-faces.el @@ -44,6 +44,9 @@ (set-face-doc-string new-face docstring))))) (put 'org-copy-face 'lisp-indent-function 2) +(when (featurep 'xemacs) + (put 'mode-line 'face-alias 'modeline)) + (defgroup org-faces nil "Faces in Org-mode." :tag "Org Faces" From 305f29776fba57cdd1566071e0e8a75270d095c6 Mon Sep 17 00:00:00 2001 From: Achim Gratz Date: Sun, 6 Jan 2013 18:29:05 +0100 Subject: [PATCH 3/3] Compatibility: Use org-define-obsolete-{function,variable}-alias MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * lisp/org-compat.el (org-define-obsolete-function-alias, org-define-obsolete-variable-alias): Introduce new compatibility macros to obsolete functions and variables. * lisp/org-agenda.el, lisp/org-clock.el, lisp/org-id.el, lisp/org-lparse.el, lisp/org-protocol.el lisp/org.el: Use `org-define-obsolete-{function,variable}-alias´instead of `define-obsolate{function,variable}-alias´. --- lisp/org-agenda.el | 6 +++--- lisp/org-clock.el | 2 +- lisp/org-compat.el | 18 ++++++++++++++++++ lisp/org-id.el | 2 +- lisp/org-lparse.el | 4 ++-- lisp/org-protocol.el | 6 +++--- lisp/org.el | 13 ++++--------- 7 files changed, 32 insertions(+), 19 deletions(-) diff --git a/lisp/org-agenda.el b/lisp/org-agenda.el index 1b2337cd1..b4c21fcb5 100644 --- a/lisp/org-agenda.el +++ b/lisp/org-agenda.el @@ -890,7 +890,7 @@ you want to use two-columns display (see `org-agenda-menu-two-columns')." :version "24.1" :type 'boolean) -(define-obsolete-variable-alias 'org-agenda-menu-two-column 'org-agenda-menu-two-columns "24.3") +(org-define-obsolete-variable-alias 'org-agenda-menu-two-column 'org-agenda-menu-two-columns "24.3") (defcustom org-agenda-menu-two-columns nil "Non-nil means, use two columns to show custom commands in the dispatcher. @@ -900,7 +900,7 @@ to nil." :version "24.1" :type 'boolean) -(define-obsolete-variable-alias 'org-finalize-agenda-hook 'org-agenda-finalize-hook "24.3") +(org-define-obsolete-variable-alias 'org-finalize-agenda-hook 'org-agenda-finalize-hook "24.3") (defcustom org-agenda-finalize-hook nil "Hook run just before displaying an agenda buffer. The buffer is still writable when the hook is called. @@ -7681,7 +7681,7 @@ When called with a prefix argument, include all archive files as well." ""))) (force-mode-line-update)) -(define-obsolete-function-alias +(org-define-obsolete-function-alias 'org-agenda-post-command-hook 'org-agenda-update-agenda-type "24.3") (defun org-agenda-update-agenda-type () diff --git a/lisp/org-clock.el b/lisp/org-clock.el index a481ac577..e3048e5a1 100644 --- a/lisp/org-clock.el +++ b/lisp/org-clock.el @@ -204,7 +204,7 @@ file name play this sound file. If not possible, fall back to beep" (const :tag "Standard beep" t) (file :tag "Play sound file"))) -(define-obsolete-variable-alias 'org-clock-modeline-total +(org-define-obsolete-variable-alias 'org-clock-modeline-total 'org-clock-mode-line-total "24.3") (defcustom org-clock-mode-line-total 'auto diff --git a/lisp/org-compat.el b/lisp/org-compat.el index 8f21321cb..815087534 100644 --- a/lisp/org-compat.el +++ b/lisp/org-compat.el @@ -169,6 +169,24 @@ If DELETE is non-nil, delete all those overlays." (set-buffer-modified-p modified-p)) (decompose-region beg end))) +(defmacro org-define-obsolete-function-alias (o-name c-name when &optional doc) + "Reconcile the two-argument form of +`define-obsolete-function-alias' in XEmacs/Emacs 22 with the 3-4 +argument form in Emacs 23 and later." + (if (or (featurep 'xemacs) + (< emacs-major-version 23)) + `(define-obsolete-function-alias ,o-name ,c-name) + `(define-obsolete-function-alias ,o-name ,c-name ,when ,doc))) + +(defmacro org-define-obsolete-variable-alias (o-name c-name when &optional doc) + "Reconcile the two-argument form of +`define-obsolete-variable-alias' in XEmacs/Emacs 22 with the 3-4 +argument form in Emacs 23 and later." + (if (or (featurep 'xemacs) + (< emacs-major-version 23)) + `(define-obsolete-variable-alias ,o-name ,c-name) + `(define-obsolete-variable-alias ,o-name ,c-name ,when ,doc))) + ;; Miscellaneous functions (defun org-add-hook (hook function &optional append local) diff --git a/lisp/org-id.el b/lisp/org-id.el index 6e865b50c..5d8e5b0dc 100644 --- a/lisp/org-id.el +++ b/lisp/org-id.el @@ -83,7 +83,7 @@ :tag "Org ID" :group 'org) -(define-obsolete-variable-alias +(org-define-obsolete-variable-alias 'org-link-to-org-use-id 'org-id-link-to-org-use-id "24.3") (defcustom org-id-link-to-org-use-id nil "Non-nil means storing a link to an Org file will use entry IDs. diff --git a/lisp/org-lparse.el b/lisp/org-lparse.el index 11711353f..e9fbbea58 100644 --- a/lisp/org-lparse.el +++ b/lisp/org-lparse.el @@ -1718,7 +1718,7 @@ information." (org-lparse-end-paragraph) (org-lparse-end-list-item (or type "u"))) -(define-obsolete-function-alias +(org-define-obsolete-function-alias 'org-lparse-preprocess-after-blockquote-hook 'org-lparse-preprocess-after-blockquote "24.3") @@ -1736,7 +1736,7 @@ information." (format "ORG-%s-END %s" (upcase (match-string 2)) (match-string 3))) t t)))) -(define-obsolete-function-alias +(org-define-obsolete-function-alias 'org-lparse-strip-experimental-blocks-maybe-hook 'org-lparse-strip-experimental-blocks-maybe "24.3") diff --git a/lisp/org-protocol.el b/lisp/org-protocol.el index 9eaf6420b..092596490 100644 --- a/lisp/org-protocol.el +++ b/lisp/org-protocol.el @@ -128,15 +128,15 @@ (filename &optional up)) (declare-function server-edit "server" (&optional arg)) -(define-obsolete-function-alias +(org-define-obsolete-function-alias 'org-protocol-unhex-compound 'org-link-unescape-compound "2011-02-17") -(define-obsolete-function-alias +(org-define-obsolete-function-alias 'org-protocol-unhex-string 'org-link-unescape "2011-02-17") -(define-obsolete-function-alias +(org-define-obsolete-function-alias 'org-protocol-unhex-single-byte-sequence 'org-link-unescape-single-byte-sequence "2011-02-17") diff --git a/lisp/org.el b/lisp/org.el index 644b7601f..ea19f97ff 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -7402,12 +7402,7 @@ even level numbers will become the next higher odd number." ((< change 0) (max 1 (1+ (* 2 (/ (+ level (* 2 change)) 2)))))) (max 1 (+ level (or change 0))))) -(if (boundp 'define-obsolete-function-alias) - (if (or (featurep 'xemacs) (< emacs-major-version 23)) - (define-obsolete-function-alias 'org-get-legal-level - 'org-get-valid-level) - (define-obsolete-function-alias 'org-get-legal-level - 'org-get-valid-level "23.1"))) +(org-define-obsolete-function-alias 'org-get-legal-level 'org-get-valid-level "23.1") (defvar org-called-with-limited-levels nil) ;; Dynamically bound in ;; ̀org-with-limited-levels' @@ -17789,7 +17784,7 @@ BEG and END default to the buffer boundaries." (list 'org-display-inline-remove-overlay)) (push ov org-inline-image-overlays))))))))) -(define-obsolete-function-alias +(org-define-obsolete-function-alias 'org-display-inline-modification-hook 'org-display-inline-remove-overlay "24.3") (defun org-display-inline-remove-overlay (ov after beg end &optional len) @@ -18169,7 +18164,7 @@ If not, return to the original position and throw an error." (defvar org-table-auto-blank-field) ; defined in org-table.el (defvar org-speed-command nil) -(define-obsolete-function-alias +(org-define-obsolete-function-alias 'org-speed-command-default-hook 'org-speed-command-activate "24.3") (defun org-speed-command-activate (keys) @@ -18182,7 +18177,7 @@ Use `org-speed-commands-user' for further customization." (cdr (assoc keys (append org-speed-commands-user org-speed-commands-default))))) -(define-obsolete-function-alias +(org-define-obsolete-function-alias 'org-babel-speed-command-hook 'org-babel-speed-command-activate "24.3") (defun org-babel-speed-command-activate (keys)