From c5977e7e9d4ccf0c9ed0dde35827dab61f48ff74 Mon Sep 17 00:00:00 2001 From: Achim Gratz Date: Tue, 11 Sep 2012 21:42:38 +0200 Subject: [PATCH] Revert "org-compat.el: New compatibility function `org-random'" This reverts commit 7719734dd7b216e29ee7f5be5077d13004903a7d. * lisp/org-id.el: Do not use (random t), we just want a new random number, not a re-seeding of the PRNG for which (random t) doesn't provide enough entropy anyway. Even if (random) would always produce the same sequence, the other components going into the MD5 hash ensure that the result will be unique. --- lisp/org-compat.el | 6 ------ lisp/org-id.el | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/lisp/org-compat.el b/lisp/org-compat.el index 7c65233bd..760428496 100644 --- a/lisp/org-compat.el +++ b/lisp/org-compat.el @@ -460,12 +460,6 @@ With two arguments, return floor and remainder of their quotient." (defun org-release () "N/A") (defun org-git-version () "N/A !!check installation!!")))))) -(defun org-random () - "Call ̀€random' appropriately." - (if (or (featurep 'xemacs) (version< emacs-version "24.2.50.1")) - (random t) - (random))) - (provide 'org-compat) ;;; org-compat.el ends here diff --git a/lisp/org-id.el b/lisp/org-id.el index 365b35a27..359d8233d 100644 --- a/lisp/org-id.el +++ b/lisp/org-id.el @@ -317,7 +317,7 @@ So a typical ID could look like \"Org:4nd91V40HI\"." (defun org-id-uuid () "Return string with random (version 4) UUID." (let ((rnd (md5 (format "%s%s%s%s%s%s%s" - (org-random) + (random) (current-time) (user-uid) (emacs-pid)