mirrors/org-mode
0
0
Fork 1
mirror of https://git.savannah.gnu.org/git/emacs/org-mode.git synced 2024-09-29 18:36:26 +00:00
Code Releases Activity

org-element-cache: Give user more control over silent modificatoin checks

Browse source 
* lisp/org-element.el (org-element--cache-silent-modification-check):
New variable allowing the user to suppress modification checks completely.
* lisp/org-element.el (org-element--cache-sync): Support
`org-element--cache-silent-modification-check'.

The existing heuristics for built-in non-modifying commands that
change `buffer-chars-modified-tick' is not sufficient.  At least
`capitalize-word' changes the tick regardless whether the buffer was
actually modified or not.  Yet, `capitalize-word' does not call
`after-change-functions' if the buffer is not really modified.

Reported in https://list.orgmode.org/2022-01-06T12-13-17@devnull.Karl-Voit.at/T/#mb3771758f81b31721ba2f420878a4d16081dc483
This commit is contained in:
Ihor Radchenko 2022-01-06 20:12:01 +08:00
parent b8656a2cef
commit a98ae424d2
No known key found for this signature in database
GPG key ID: 6470762A7DA11D8B
1 changed files with 15 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
lisp/org-element.el
View file

@ -5321,6 +5321,17 @@ can change `buffer-chars-modified-tick' internally even though no
visible changes in buffer are being made. Some of such expected cases visible changes in buffer are being made. Some of such expected cases
are covered by heuristics, but not all.") are covered by heuristics, but not all.")
(defvar org-element--cache-silent-modification-check t
"Detect changes in buffer made inside `with-silent-modifications'.
Note that some internal Emacs functions may also trigger a warning and
cache reset. The warning can be suppressed by setting
`org-element--cache-diagnostics-modifications' to nil, but the cache
will still be refreshed to be safe.
WARNING: Setting this variable to nil may cause cache corruption is some
third-party packages make undetected changes in buffers.")
(defvar org-element--cache-diagnostics-level 2 (defvar org-element--cache-diagnostics-level 2
"Detail level of the diagnostics.") "Detail level of the diagnostics.")
@ -5859,7 +5870,8 @@ actually submitted."
;; Check if the buffer have been changed outside visibility of ;; Check if the buffer have been changed outside visibility of
;; `org-element--cache-before-change' and `org-element--cache-after-change'. ;; `org-element--cache-before-change' and `org-element--cache-after-change'.
(if (and (/= org-element--cache-change-tic (if (and (/= org-element--cache-change-tic
(buffer-chars-modified-tick)) (buffer-chars-modified-tick))
org-element--cache-silent-modification-check
;; FIXME: Below is a heuristics noticed by observation. ;; FIXME: Below is a heuristics noticed by observation.
;; quail.el with non-latin input does silent ;; quail.el with non-latin input does silent
;; modifications in buffer increasing the tick counter ;; modifications in buffer increasing the tick counter
@ -5878,7 +5890,8 @@ actually submitted."
;; A number of Emacs internal operations in ;; A number of Emacs internal operations in
;; Emacs 26 and 27 alter ;; Emacs 26 and 27 alter
;; `buffer-chars-modified-tick' (see ;; `buffer-chars-modified-tick' (see
;; https://list.orgmode.org/87ee7jdv70.fsf@localhost/T/#t). ;; https://list.orgmode.org/87ee7jdv70.fsf@localhost/T/#t
;; https://list.orgmode.org/2022-01-06T12-13-17@devnull.Karl-Voit.at/T/#mb3771758f81b31721ba2f420878a4d16081dc483).
;; We have no way to distinguish them from ;; We have no way to distinguish them from
;; dangerious silent edits. So, we can ;; dangerious silent edits. So, we can
;; only reset the cache, but do not show ;; only reset the cache, but do not show