tec/org-mode
tec/org-mode
1
0
Fork 0
forked from mirrors/org-mode
Code Pull requests Releases Activity

org-odt.el: Fix performance issue on manifest file writing

Browse source 
* contrib/lisp/org-odt.el (org-odt-write-manifest-file): Don't
use write-region.

The org-odt-write-manifest-file function take too much time -
several seconds for 164 files. This patch provides a cheaper
implementation (hundredths of a seconds for 164 files).

Original patch by Jérémy Compostella
<jeremy.compostella@gmail.com>.  Rewritten by Jambunathan K to
minimize the actual number of lines changed.

TINYCHANGE.

From http://www.mail-archive.com/emacs-orgmode@gnu.org/msg49248.html
I'm currently generating a road book for a trip from different
Org-Mode file and other data. It results in a 13 thousands
lines Org-Mode file and I have some performance issues. Using
the ELP package, I isolated the two main bottlenecks.

One is in org-odt : the org-odt-write-manifest-file function
is called once and takes 5.546672 seconds to write a 167 lines
file. I rewrote this function and now it takes 0.01606 seconds
to write the same file.
This commit is contained in:
Jambunathan K 2011-11-24 23:46:34 +05:30
parent 5a24ffe004
commit 2ded8ccb85
1 changed files with 16 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
contrib/lisp/org-odt.el
View file

@ -1959,21 +1959,22 @@ visually."
(defun org-odt-write-manifest-file () (defun org-odt-write-manifest-file ()
(make-directory "META-INF") (make-directory "META-INF")
(let ((manifest-file (expand-file-name "META-INF/manifest.xml"))) (let ((manifest-file (expand-file-name "META-INF/manifest.xml")))
(write-region (with-current-buffer
"<?xml version=\"1.0\" encoding=\"UTF-8\"?> (find-file-noselect manifest-file t)
<manifest:manifest xmlns:manifest=\"urn:oasis:names:tc:opendocument:xmlns:manifest:1.0\" manifest:version=\"1.2\">\n" (insert
nil manifest-file) "<?xml version=\"1.0\" encoding=\"UTF-8\"?>
(mapc <manifest:manifest xmlns:manifest=\"urn:oasis:names:tc:opendocument:xmlns:manifest:1.0\" manifest:version=\"1.2\">\n")
(lambda (file-entry) (mapc
(let* ((version (nth 2 file-entry)) (lambda (file-entry)
(extra (if version (let* ((version (nth 2 file-entry))
(format " manifest:version=\"%s\"" version) (extra (if version
""))) (format " manifest:version=\"%s\"" version)
(write-region "")))
(format org-odt-manifest-file-entry-tag (insert
(nth 0 file-entry) (nth 1 file-entry) extra) (format org-odt-manifest-file-entry-tag
nil manifest-file t))) org-odt-manifest-file-entries) (nth 0 file-entry) (nth 1 file-entry) extra))))
(write-region "\n</manifest:manifest>" nil manifest-file t))) org-odt-manifest-file-entries)
(insert "\n</manifest:manifest>"))))
(defun org-odt-update-meta-file (opt-plist) (defun org-odt-update-meta-file (opt-plist)
(let ((date (org-odt-iso-date-from-org-timestamp (let ((date (org-odt-iso-date-from-org-timestamp