From 565361eb698b0b39c1d823ad1565f5bd88fa2034 Mon Sep 17 00:00:00 2001 From: Nicolas Goaziou Date: Thu, 1 Jul 2021 12:11:28 +0200 Subject: [PATCH] org-keys: Do not bind , ever Fixes: `org-mode-map` binds `` which is unnecessary and harmful, since it takes precendence over bindings of TAB even in keymaps with higher precedence. Reported-by: Daniel Mendler --- lisp/org-keys.el | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/lisp/org-keys.el b/lisp/org-keys.el index f0fdb79ea..4cb03b091 100644 --- a/lisp/org-keys.el +++ b/lisp/org-keys.el @@ -337,7 +337,6 @@ COMMANDS is a list of alternating OLDDEF NEWDEF command names." (org-defkey org-mouse-map [follow-link] 'mouse-face)) (when org-tab-follows-link - (org-defkey org-mouse-map (kbd "") #'org-open-at-point) (org-defkey org-mouse-map (kbd "TAB") #'org-open-at-point)) @@ -443,18 +442,13 @@ COMMANDS is a list of alternating OLDDEF NEWDEF command names." (org-defkey org-mode-map (kbd "C-c C-x") (make-sparse-keymap)) ;;;; TAB key with modifiers -(org-defkey org-mode-map (kbd "C-i") #'org-cycle) -(org-defkey org-mode-map (kbd "") #'org-cycle) -(org-defkey org-mode-map (kbd "C-c C-") #'org-force-cycle-archived) +(org-defkey org-mode-map (kbd "TAB") #'org-cycle) +(org-defkey org-mode-map (kbd "C-c C-TAB") #'org-force-cycle-archived) ;; Override text-mode binding to expose `complete-symbol' for ;; pcomplete functionality. -(org-defkey org-mode-map (kbd "M-") nil) (org-defkey org-mode-map (kbd "M-TAB") nil) -(org-defkey org-mode-map (kbd "ESC ") nil) (org-defkey org-mode-map (kbd "ESC TAB") nil) -(org-defkey org-mode-map (kbd "") #'org-shifttab) -(org-defkey org-mode-map (kbd "S-") #'org-shifttab) (org-defkey org-mode-map (kbd "S-TAB") #'org-shifttab) (define-key org-mode-map (kbd "") #'org-shifttab)