diff --git a/lisp/ob-octave.el b/lisp/ob-octave.el index b0a7767ec..8953b6751 100644 --- a/lisp/ob-octave.el +++ b/lisp/ob-octave.el @@ -91,7 +91,7 @@ end") (list "set (0, \"defaultfigurevisible\", \"off\");" full-body - (format "print -dpng %s" gfx-file)) + (format "print -dpng %S\nans=%S" gfx-file gfx-file)) "\n") full-body) result-type matlabp))) diff --git a/testing/examples/ob-octave-test.org b/testing/examples/ob-octave-test.org index 9839d637e..bc19051a1 100644 --- a/testing/examples/ob-octave-test.org +++ b/testing/examples/ob-octave-test.org @@ -46,10 +46,18 @@ ans = s * Graphical tests -#+begin_src octave :results graphics :file chart.png + +Graphics file. This test is performed by =ob-octave/graphics-file= in =testing/lisp/test-ob-octave.el=. +#+begin_src octave :results file graphics :file sombrero.png sombrero; #+end_src -#+begin_src octave :session +Graphics file in a session. This test is performed by =ob-octave/graphics-file-session= in =testing/lisp/test-ob-octave.el=. +#+begin_src octave :session :results graphics file :file sombrero.png +sombrero; +#+end_src + +Graphics file with a space in name. This test is performed by =ob-octave/graphics-file-space= in =testing/lisp/test-ob-octave.el=. +#+begin_src octave :results graphics file :file sombrero hat.png sombrero; #+end_src diff --git a/testing/lisp/test-ob-octave.el b/testing/lisp/test-ob-octave.el index 78ce10214..57f40d00b 100644 --- a/testing/lisp/test-ob-octave.el +++ b/testing/lisp/test-ob-octave.el @@ -64,4 +64,69 @@ (org-babel-next-src-block 5) (should (equal nil (org-babel-execute-src-block))))) +(ert-deftest ob-octave/graphics-file () + "Graphics file. Test that link is correctly inserted and graphics file is created (and not empty). Clean-up side-effects." + ;; In case a prior test left the Error Output buffer hanging around. + (when (get-buffer "*Org-Babel Error Output*") + (kill-buffer "*Org-Babel Error Output*")) + (let ((file (make-temp-file "test-ob-octave-" nil ".png"))) + (unwind-protect + (org-test-with-temp-text + (format "#+begin_src octave :results file graphics :file %s +sombrero; +#+end_src" + file) + (org-babel-execute-src-block) + (should (search-forward (format "[[file:%s]]" file) nil nil)) + (should (file-readable-p file)) + (should (> (file-attribute-size (file-attributes file)) 0)) + (should-not (get-buffer "*Org-Babel Error Output*"))) + ;; clean-up + (delete-file file) + (when (get-buffer "*Org-Babel Error Output*") + (kill-buffer "*Org-Babel Error Output*"))))) + +(ert-deftest ob-octave/graphics-file-session () + "Graphics file in a session. Test that session is started in *Inferior Octave* buffer, link is correctly inserted and graphics file is created (and not empty). Clean-up side-effects." + (let ((file (make-temp-file "test-ob-octave-" nil ".png"))) + (unwind-protect + (org-test-with-temp-text + (format "#+begin_src octave :session :results file graphics :file %s +crash_dumps_octave_core(0); +sombrero; +#+end_src" + file) + (org-babel-execute-src-block) + (should (get-buffer "*Inferior Octave*")) + (should (search-forward (format "[[file:%s]]" file) nil nil)) + (should (file-readable-p file)) + (should (> (file-attribute-size (file-attributes file)) 0)) + (should-not (get-buffer "*Org-Babel Error Output*"))) + ;; clean-up + (delete-file file) + (let (kill-buffer-query-functions kill-buffer-hook) + (kill-buffer "*Inferior Octave*")) + (when (get-buffer "*Org-Babel Error Output*") + (kill-buffer "*Org-Babel Error Output*"))))) + +(ert-deftest ob-octave/graphics-file-space () + "Graphics file with a space in filename. Test that session is started in *Inferior Octave* buffer, link is correctly inserted and graphics file is created (and not empty). Clean-up side-effects." + (let ((file (make-temp-file "test ob octave-" nil ".png"))) + (unwind-protect + (org-test-with-temp-text + (format "#+begin_src octave :results file graphics :file %s +sombrero; +#+end_src" + file) + (org-babel-execute-src-block) + (should (search-forward (format "[[file:%s]]" file) nil nil)) + (should (file-readable-p file)) + (should (> (file-attribute-size (file-attributes file)) 0)) + (should-not (get-buffer "*Org-Babel Error Output*"))) + ;; clean-up + (delete-file file) + (when (get-buffer "*Org-Babel Error Output*") + (kill-buffer "*Org-Babel Error Output*"))))) + + (provide 'test-ob-octave)