From 9afcc02588e842e5792e65508bb7719355ace352 Mon Sep 17 00:00:00 2001 From: Aidan Kehoe Date: Sun, 22 Aug 2010 04:17:04 +0000 Subject: [PATCH] Use integer syntax for the MODE argument to #'set-file-modes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hello! We need this change to get org-mode compiling with recent XEmacs 21.5. On previous 21.5 and current 21.4, the problem manifests itself at runtime, not compile time, like so: (set-file-modes "/tmp/aidan/foo.el" ?\755) => Wrong type argument: integerp, ?í One old reason to go for the ?\755 syntax instead of the #o755 syntax under GNU Emacs was to be that older versions of GNU Emacs didn’t support #o755, but, to my knowledge, every released GNU Emacs since March 2000 has supported the latter syntax. Best, Aidan Kehoe, the XEmacs project. ChangeLog addition: 2010-08-21 Aidan Kehoe * ob-tangle.el (org-babel-tangle): Change the MODE argument to #'set-file-modes to use integer, not character syntax, avoiding compile problems with recent XEmacs. --- lisp/ob-tangle.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/ob-tangle.el b/lisp/ob-tangle.el index a7ba0722a..adc054aad 100644 --- a/lisp/ob-tangle.el +++ b/lisp/ob-tangle.el @@ -187,7 +187,7 @@ exported source code blocks by language." (insert content) (write-region nil nil file-name)))) ;; if files contain she-bangs, then make the executable - (when she-bang (set-file-modes file-name ?\755)) + (when she-bang (set-file-modes file-name #o755)) ;; update counter (setq block-counter (+ 1 block-counter)) (add-to-list 'path-collector file-name)))))