From b5aaefb5517eba83ebe6fcde0d2fa580a9d1e449 Mon Sep 17 00:00:00 2001 From: Ihor Radchenko Date: Sat, 12 Aug 2023 11:17:15 +0300 Subject: [PATCH] org-babel-variable-assignments:eshell: Prevent leaking values into results * lisp/ob-eshell.el (org-babel-variable-assignments:eshell): Wrap `setq' eshell call into `ignore' to prevent the variable assignment values leaking into block output. Fixes `ob-eshell/variables-assignment'. --- lisp/ob-eshell.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/ob-eshell.el b/lisp/ob-eshell.el index 95f5777ae..fa19f874a 100644 --- a/lisp/ob-eshell.el +++ b/lisp/ob-eshell.el @@ -97,7 +97,8 @@ The PARAMS are variables assignments." "Convert ob-eshell :var specified variables into Eshell variables assignments." (mapcar (lambda (pair) - (format "(setq %s %S)" (car pair) (cdr pair))) + ;; Use `ignore' to suppress value in the command output. + (format "(ignore (setq %s %S))" (car pair) (cdr pair))) (org-babel--get-vars params))) (defun org-babel-load-session:eshell (session body params)