diff --git a/lisp/org-clock.el b/lisp/org-clock.el index d46458536..a300df8ff 100644 --- a/lisp/org-clock.el +++ b/lisp/org-clock.el @@ -728,9 +728,9 @@ If not, show simply the clocked time like 01:50." 'org-mode-line-clock-overrun 'org-mode-line-clock))) (effort-str (org-duration-from-minutes effort-in-minutes))) - (format (propertize " [%s/%s] (%s)" 'face 'org-mode-line-clock) + (format (propertize "[%s/%s] (%s) " 'face 'org-mode-line-clock) work-done-str effort-str org-clock-heading)) - (format (propertize " [%s] (%s)" 'face 'org-mode-line-clock) + (format (propertize "[%s] (%s) " 'face 'org-mode-line-clock) (org-duration-from-minutes clocked-time) org-clock-heading)))) diff --git a/testing/lisp/test-org-clock.el b/testing/lisp/test-org-clock.el index f732e471a..a1ca9e25b 100644 --- a/testing/lisp/test-org-clock.el +++ b/testing/lisp/test-org-clock.el @@ -1276,5 +1276,40 @@ CLOCK: [2012-03-29 Thu 16:00]--[2012-03-29 Thu 17:00] => 1:00" (test-org-clock-clocktable-contents (format ":hidefiles t :scope (lambda () (list %S))" the-file)))))))) +;;; Mode line + +(ert-deftest test-org-clock/mode-line () + "Test mode line string ends in a space. + +\"Elements that are added to [the mode line] should normally end +in a space (to ensure that consecutive 'global-mode-string' +elements display properly)\" per Emacs manual, Section 24.4.4 +Variables Used in the Mode Line." + ;; Test the variant without effort. + (should + (equal + " [0:00] (Heading) " + (org-test-with-temp-text + "* Heading" + (org-clock-in) + (prog1 (concat " " + (org-clock-get-clock-string) + " ") + (org-clock-out))))) + ;; Test the variant with effort. + (should + (equal + " [0:00/1:00] (Heading) " + (org-test-with-temp-text + "* Heading +:PROPERTIES: +:EFFORT: 1h +:END:" + (org-clock-in) + (prog1 (concat " " + (org-clock-get-clock-string) + " ") + (org-clock-out)))))) + (provide 'test-org-clock) ;;; test-org-clock.el end here