mirrors
/
org-mode
mirror of https://git.savannah.gnu.org/git/emacs/org-mode.git
0
0
Fork 1
Code Releases Activity

ox-texinfo: Gracefully handle node collision in the same hierarchy 

* lisp/ox-texinfo.el (org-texinfo--get-node): Ensure the upper element
  get the shorter node.

Considering the following document:

* Headline
** Headline

the level 1 headlines get "Headline" node and the other one
"Headline (1)".
This commit is contained in:
Nicolas Goaziou 2017-11-05 12:22:18 +01:00
parent 04f35fc473
commit 8d43a0c49f
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
lisp/ox-texinfo.el
View File

@ -486,6 +486,17 @@ node or anchor name is unique."
(type
(error "Cannot generate node name for type: %S" type)))))
(name basename))
;; Org exports deeper elements before their parents. If two
;; node names collide -- e.g., they have the same title --
;; within the same hierarchy, the second one would get the
;; shorter node name. This is counter-intuitive.
;; Consequently, we ensure that every parent headline get
;; its node beforehand. As a recursive operation, this
;; achieves the desired effect.
(let ((parent (org-element-lineage datum '(headline))))
(when (and parent (not (assq parent cache)))
(org-texinfo--get-node parent info)
(setq cache (plist-get info :texinfo-node-cache))))
;; Ensure NAME is unique and not reserved node name "Top".
(while (or (equal name "Top") (rassoc name cache))
(setq name (concat basename (format " (%d)" (cl-incf salt)))))