mirrors
/
org-mode
mirror of https://git.savannah.gnu.org/git/emacs/org-mode.git
0
0
Fork 1
Code Releases Activity

org-element--cache-sync: Fix warning about unregistered modifications 

* lisp/org-element.el (org-element--cache-diagnostics-modifications):
New variable to enable/disable warnings when unregistered
modifications are detected in Org buffers.
* lisp/org-element.el (org-element--cache-sync): Only show
"Unregistered modification" warning when
`org-element--cache-diagnostics-modifications' is non-nil or during
Org tests.  Add special handling for unregistered changes by
`replace-match' in Emacs <28.

Fixes https://list.orgmode.org/87pmr6lu1y.fsf@localhost/T/#t
This commit is contained in:
Ihor Radchenko 2021-11-14 14:32:20 +08:00
parent d8606c316e
commit c3f4573758
No known key found for this signature in database
GPG Key ID: 6470762A7DA11D8B
1 changed files with 27 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
lisp/org-element.el
View File

@ -5306,6 +5306,17 @@ to be correct. Setting this to a value less than 0.0001 is useless.")
(defvar org-element--cache-map-statistics-threshold 0.1
"Time threshold in seconds to log statistics for `org-element-cache-map'.")
(defvar org-element--cache-diagnostics-modifications t
"Non-nil enables cache warnings when for silent modifications.
Silent modifications are the modifications in Org buffers that are not
registered by `org-element--cache-before-change' and `org-element--cache-after-change'.
This variable may cause false-positives because some Emacs versions
can change `buffer-chars-modified-tick' internally even though no
visible changes in buffer are being made. Some of such expected cases
are covered by heuristics, but not all.")
(defvar org-element--cache-diagnostics-level 2
"Detail level of the diagnostics.")
@ -5849,16 +5860,25 @@ updated before current modification are actually submitted."
;; consider these exact changes as a dangerous silent
;; edit.
(/= (buffer-chars-modified-tick)
(buffer-modified-tick)))
(buffer-modified-tick))
;; FIXME: Another heuristics noticed by observation.
;; `replace-match' in `org-toggle-heading' in Emacs <28
;; makes safe silent changes when first letter in the
;; line is a cyrillic capital letter.
;; https://list.orgmode.org/87pmr6lu1y.fsf@localhost/T/#t
(not (= (buffer-chars-modified-tick)
(- (buffer-modified-tick) 7))))
(progn
(org-element--cache-warn "Unregistered buffer modifications detected. Resetting.
(when (or org-element--cache-diagnostics-modifications
(and (boundp 'org-batch-test) org-batch-test))
(org-element--cache-warn "Unregistered buffer modifications detected. Resetting.
If this warning appears regularly, please report it to Org mode mailing list (M-x org-submit-bug-report).
The buffer is: %s\n Current command: %S\n Backtrace:\n%S"
(buffer-name (current-buffer))
this-command
(when (and (fboundp 'backtrace-get-frames)
(fboundp 'backtrace-to-string))
(backtrace-to-string (backtrace-get-frames 'backtrace))))
(buffer-name (current-buffer))
this-command
(when (and (fboundp 'backtrace-get-frames)
(fboundp 'backtrace-to-string))
(backtrace-to-string (backtrace-get-frames 'backtrace)))))
(org-element-cache-reset))
(let ((inhibit-quit t) request next)
(setq org-element--cache-interrupt-C-g-count 0)