f2eec6921f
* lisp/org-publish.el (org-publish-attachment): Put the attachment into the right directory. Aidan Gauland <aidalgol@no8wireless.co.nz> writes: > On Thu, Sep 16, 2010 at 12:40:34AM +0200, Sebastian Rose wrote: >> Aidan Gauland <aidalgol@no8wireless.co.nz> writes: >> > Sebastian Rose <sebastian_rose <at> gmx.de> writes: >> >> It would be a bug. >> >> >> >> But I cannot reproduce it (current Org mode from git, emacs24). >> > >> > I just figured out why: I store all my images in ~/images/ and just >> > have symbolic links to them in my Org website directory. >> > >> > Can you reproduce it now that you have this piece of information? >> >> >> Ah, OK. That might be because of some call to >> >> (file-truename file...) >> >> or similar. `file-truename' removes symbolic links in filenames. >> >> Functions like this are called to make sure, the file is published only >> if needed (i.e. the file has changed since last export). >> >> I'm not sure currently if it's clever to remove such calls (see >> lisp/org-publish.el and search `file-truename'). > > What if `file-truename' was used only to get the path of the actual > file to copy, but the (relative) path of the link is used as the > destination? > > --Aidan Hi Aidan, `org-publish-attachment' is wrong or called with wrong arguments. This patch fixes it. As always, there might be a better way to fix it, but this way the function `org-publish-attachment' will work regardless of parameters. Someone will always call this function with the wrong `PUB-DIR' parameter... Aidan, would like to apply the patch and verify it works for you? Best wishes, Sebastian |
||
|---|---|---|
| BUGFIXING | ||
| EXPERIMENTAL | ||
| ORGWEBPAGE | ||
| UTILITIES | ||
| contrib | ||
| doc | ||
| lisp | ||
| testing/org-html | ||
| .dir-locals.el | ||
| .dir-settings.el | ||
| .gitignore | ||
| Makefile | ||
| README | ||
| README_DIST | ||
| README_GIT | ||
| request-assign-future.txt | ||
README
This is the Emacs Org project, an emacs subsystem for organizing your life
The homepage of Org is at http://orgmode.org
This distribution contains:
README
This file.
README_DIST
The README file for the distribution (zip and tar files)
README_GIT
Information about the git repository and how to contribute
to Org-mode development.
lisp/
Directory with all the Emacs Lisp files that make up Org.
doc/
The documentation files. org.texi is the source of the
documentation, org.html and org.pdf are formatted versions of it.
contrib/
A directory with third-party additions for Org. Some really cool
stuff is in there.
ORGWEBPAGE/
Directory with the source files for the orgmode.org web page.
ChangeLog
The standard ChangeLog file.
Makefile
The makefile to compile and install Org, and also for maintenance
tasks.
request-assign-future.txt
The form that contributors have to sign and get processed with the
FSF before contributed changes can be integrated into the Org
core. All files in this distribution except the CONTRIB directory
have copyright assigned to the FSF.
EXPERIMENTAL
Experimental code, not necessarily FSF copyright.