forked from mirrors/org-mode
Revert "org-babel-read: Obey `org-confirm-babel-evaluate'"
This reverts commit 10e857d428
.
* lisp/ob-core.el:
(org-babel-merge-params):
(org-babel-process-params):
(org-babel-read):
* lisp/org-table.el: Add FIXME comments to places where arbitrary code
execution may happen.
The extra query is reverted until we develop a better code execution
safety system for Org. The commit introduced too many user queries,
making the whole idea of asking users to execute code from Org files
not useful.
Link: https://orgmode.org/list/878rinadlq.fsf@localhost
This commit is contained in:
parent
1cd39c9e30
commit
3454021483
|
@ -1690,6 +1690,7 @@ shown below.
|
|||
(append
|
||||
(split-string (if (stringp raw-result)
|
||||
raw-result
|
||||
;; FIXME: Arbitrary code evaluation.
|
||||
(eval raw-result t)))
|
||||
(cdr (assq :result-params params))))))
|
||||
(append
|
||||
|
@ -2860,6 +2861,7 @@ parameters when merging lists."
|
|||
(split-string
|
||||
(cond ((stringp value) value)
|
||||
((functionp value) (funcall value))
|
||||
;; FIXME: Arbitrary code evaluation.
|
||||
(t (eval value t)))))))
|
||||
(`(:exports . ,value)
|
||||
(setq exports (funcall merge
|
||||
|
@ -3188,16 +3190,8 @@ situations in which is it not appropriate."
|
|||
((and (not inhibit-lisp-eval)
|
||||
(or (memq (string-to-char cell) '(?\( ?' ?` ?\[))
|
||||
(string= cell "*this*")))
|
||||
;; Prevent arbitrary function calls.
|
||||
(if (and (memq (string-to-char cell) '(?\( ?`))
|
||||
(not (org-babel-confirm-evaluate
|
||||
;; See `org-babel-get-src-block-info'.
|
||||
(list "emacs-lisp" cell
|
||||
'((:eval . yes)) nil (format "%s" cell)
|
||||
nil nil))))
|
||||
;; Not allowed.
|
||||
(user-error "Evaluation of elisp code %S aborted." cell)
|
||||
(eval (read cell) t)))
|
||||
;; FIXME: Arbitrary code evaluation.
|
||||
(eval (read cell) t))
|
||||
((save-match-data
|
||||
(and (string-match "^[[:space:]]*\"\\(.*\\)\"[[:space:]]*$" cell)
|
||||
(not (string-match "[^\\]\"" (match-string 1 cell)))))
|
||||
|
|
|
@ -2614,6 +2614,7 @@ location of point."
|
|||
|
||||
(if lispp
|
||||
(setq ev (condition-case nil
|
||||
;; FIXME: Arbitrary code evaluation.
|
||||
(eval (eval (read form)))
|
||||
(error "#ERROR"))
|
||||
ev (if (numberp ev) (number-to-string ev) ev)
|
||||
|
|
Loading…
Reference in New Issue