tec
/
screenshot.el
1
0
Fork 0
Code Issues 2 Pull Requests Releases Activity

Wrongly labeled config option #5

New Issue
Closed
opened 2021-03-22 14:14:05 +00:00 by thomasheartman · 3 comments
thomasheartman commented 2021-03-22 14:14:05 +00:00 (Migrated from github.com)
Copy Link

Hey! Great work in this package; it's a nice little quality of life improvement!

I just wanted to report what I believe is a typo (a copy-paste remnant, most likely), in the configuration: both the '-w' and '-W' options are labeled as 'minimum width', but I think the second should be 'maximum width'. The prompt and shorthand at least corroborate this and use 'Maximum width (columns)' and 'max-width' respectively.

This screenshot is of the source code, where the second block has a remaining "Minimum width" that should be "Maximum width".

two configuration options for width, min width and max width

This concerns line 405 in the source file.

Hey! Great work in this package; it's a nice little quality of life improvement! I just wanted to report what I believe is a typo (a copy-paste remnant, most likely), in the configuration: both the '-w' and '-W' options are labeled as 'minimum width', but I think the second should be 'maximum width'. The prompt and shorthand at least corroborate this and use 'Maximum width (columns)' and 'max-width' respectively. This screenshot is of the source code, where the second block has a remaining "Minimum width" that should be "Maximum width". ![two configuration options for width, min width and max width](https://user-images.githubusercontent.com/17786332/112002148-e3618c00-8b1f-11eb-933d-9fd9419d2e36.png) This concerns [line 405 in the source file](https://github.com/tecosaur/screenshot/blob/6825ec53d2fda060dc235ee7696c6920faf7287f/screenshot.el#L405).
tecosaur commented 2021-03-29 04:49:32 +00:00 (Migrated from github.com)
Copy Link

Yep. That should be changed.

Yep. That should be changed.
thomasheartman commented 2021-03-29 20:41:54 +00:00 (Migrated from github.com)
Copy Link

Nice 😄 Do you want a PR for it? I'm happy to submit one if you wouldn't rather take care of it yourself.

Nice :smile: Do you want a PR for it? I'm happy to submit one if you wouldn't rather take care of it yourself.
tecosaur commented 2021-03-30 01:51:19 +00:00 (Migrated from github.com)
Copy Link

Nah, it's fine, but thanks for offering.

Nah, it's fine, but thanks for offering.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
v0.2
v0.1
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No Label
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: tec/screenshot.el#5
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?