Commit Graph

27680 Commits

Author SHA1 Message Date
Ihor Radchenko 915e883645
org-lint-misplaced-heading: Reduce false-positive rate
* lisp/org-lint.el (org-lint-misplaced-heading): Be more strict
matching potential misplaced headings - only do it on another heading
and inside paragraphs.

Link: https://orgmode.org/list/87a5jv77qs.fsf@gmail.com
2024-06-08 21:02:40 +02:00
Ihor Radchenko 6c862699a6
org-lint: Fix heuristics introduced in 51aea4946
* lisp/org-lint.el (org-lint-misplaced-heading): Use parser to query
whether we are inside a verbatim block.  `org-at-block-p' only
triggers on the begin line of blocks.
2024-06-07 16:53:29 +02:00
Ihor Radchenko 2f184485bf
Update version number for the 9.7.3 release 2024-06-06 16:49:56 +02:00
Ihor Radchenko e6c5f25c13
org-babel-exp-code: Fix exporting src blocks with :var arguments
* lisp/ob-exp.el (org-babel-exp-code): Do not use resolved argument
values when formatting the code block.  Resolved argument values may
contain awkward data like full (long) table contents, various Elisp
data (including non-printable), etc.  Simply using verbatim src block
parameters as they appear in the original buffer is more reliable.
(org-babel-exp-inline-code-template):
(org-babel-exp-code-template): Update docstrings, drop %flags
placeholder, which is no longer supported using the current src block
syntax.
* etc/ORG-NEWS (=ox-org= preserves header arguments in src blocks):
Drop "non-default" when explaining how header arguments are formatted.
We cannot know which values are default and which not without
resolving the values - something we cannot do as it turned out.
* testing/lisp/test-ob-exp.el (ob-exp/exports-inline-code):
(ob-export/export-src-block-with-flags):
(ob-export/body-with-coderef): Update the tests.
2024-06-06 14:44:01 +02:00
Ihor Radchenko 51aea49462
org-lint: Improve heuristics for unknown src block language
* lisp/org-lint.el (org-lint-suspicious-language-in-src-block): Do not
complain about src block languages without execute function if there
is <lang>-mode major mode available.

Reported-by: Suhail Singh <suhailsingh247@gmail.com>
Link: https://orgmode.org/list/874ja7ik7h.fsf@gmail.com
2024-06-05 17:08:50 +02:00
Ihor Radchenko 04d56f757f
mk/targets.mk (GITVERSION): Fix version string for ELPA build
* mk/targets.mk (GITVERSION): Use previous convention for the Org
version string on ELPA, where Org release tags are not available.
Instead of the new release_N/A-N/A prefix, use the Org version from
org.el file headers, as we did in Org 9.6.

Reported-by: Sharon Kimble <boudiccas@skimble09.plus.com>
Link: https://orgmode.org/list/87ikynyggt.fsf@skimble09.plus.com
2024-06-05 16:51:28 +02:00
Ihor Radchenko 223cc31ec7
org-log-beginning: Fix regression in c0b66bf
* lisp/org.el (org-log-beginning): Re-implement the bugfix attempted
in c0b66bf differently to avoid slurping blank lines when creating a
new logbook drawer.  Add more commentary to the function.

Reported-by: Christopher M. Miles <numbchild@gmail.com>

The reproducer:

* headline1
(point here)
* headline 2

(setq org-log-into-drawer t)

Press [C-c C-z] become bellowing content:

* headline1
:LOGBOOK:
- Note taken on [2024-06-05 Wed 12:49] \\
  kkk
:END:(point here)
* headline 2
2024-06-05 16:08:35 +02:00
Ihor Radchenko 589e1f38c1
Revert "org-log-beginning: Fix error creating LOGBOOK drawer at end of buffer"
This reverts commit c0b66bf9c1.

This itself caused a regression when inserting a new logbook drawer -
blank line is slurped.
2024-06-05 16:07:31 +02:00
Ihor Radchenko b8497aa7fe
org-lint: Do not warn about trailing *** lines inside blocks
* lisp/org-lint.el (org-lint-misplaced-heading): The chances that
there is a heading between #+begin... #+end lines is generally low.
So *** text instances are likely intended.

Reported-by: Suhail Singh <suhailsingh247@gmail.com>
Link: https://orgmode.org/list/87r0dc35ya.fsf@gmail.com
2024-06-05 15:13:44 +02:00
Ihor Radchenko ac1d58477a
org-element-cache: Fix indirect buffer tracking
* lisp/org-element.el (org-element--cache-setup-change-functions):
Make sure that indirect buffers are registered to be traversed in
`org-fold-core-cycle-over-indirect-buffers' in
`org-element--cache-active-p'.
`org-fold-core-decouple-indirect-buffer-folds' may not be called in
some scenarios when Org mode is active.

The reproducer that revealed the problem is in
https://orgmode.org/list/CAD6d+LUJ7St5_muvwqzE80EfHSoiMmZD+qDTAojeN0L7v+zsCQ@mail.gmail.com
2024-06-05 14:34:46 +02:00
Kyle Meyer de0df5b925
org-test: Fix zone-dependent miscalculation of days of week
* testing/org-test.el (org-test-day-of-weeks-seconds): Specify seconds
for formatting with UTC as time zone.
(org-test-day-of-weeks-abbrev):
(org-test-day-of-weeks-full): Use UTC as time zone when formatting
input.

Avoid calling format-time-string with the local time zone because that
gives the wrong result in some cases.  For example, 2222222 is
supposed to produce the locale's name for "Tuesday" but, when the
local time zone is +0000, (format-time-string "%A" 2222222) returns
the locale's name for "Monday".
2024-06-04 15:01:31 +02:00
Ihor Radchenko 2ee94bb065
Reapply "lisp/ox-html.el: Restore org-svg class."
This reverts commit 895a367a67.
2024-06-03 11:16:15 +02:00
Ihor Radchenko 77e77f051c
Reapply "ox-html: Use <img> tags for svgs, not <object>"
This reverts commit 302bc6393a.

It turns out that <object ...> tags with data pointing outside the
website are not rendered by the modern
qtwebengine (linked svgs in https://orgmode.org/tools.html are not
rendered). Even though Firefox does render the same page, it no longer
appears safe to use <object ...> for svg.  So, we have to use <img...>
with its limitations.
2024-06-03 11:14:41 +02:00
Ihor Radchenko 8e8e635eba
Revert "lisp/ox-html.el: Convert :alt to :aria-label attribute in svg images"
This reverts commit 0e5ac43324.
2024-06-03 11:14:31 +02:00
Ihor Radchenko 5f050580d8
lisp/org.el (org--dnd-attach-file): Load org-attach
This is necessary to make sure that `org-attach-method' variable is
available.
2024-06-03 11:10:07 +02:00
Ihor Radchenko 0477df8aab
org-setup-yank-dnd-handlers: Support MacOS dnd URIs
* lisp/org.el (org-setup-yank-dnd-handlers): MacOS uses
"file:/Users/juergenfenn/Desktop/test-file.jpeg" instead of file:///
stype URIs in DND data.  Handle this URI style.

We do not need to worry about converting the URI -
`org--dnd-local-file-handler' uses `dnd-get-local-file-name' that
takes care about URI-to-path conversion.

Reported-by: Juergen Fenn <jfenn@gmx.net>
Link: https://orgmode.org/list/875xur1aql.fsf@localhost
2024-06-03 11:10:06 +02:00
Kyle Meyer 671ca44df0 test-org-clock: Fix typo in test name 2024-06-01 17:10:58 -04:00
Ihor Radchenko 9ad3360d76
etc/ORG-NEWS: Fix unintentional list markup
* etc/ORG-NEWS (Images and files in clipboard can be pasted): More
"29." away from beginning of line.  It was parsed as list.
2024-06-01 20:31:17 +02:00
Ihor Radchenko 88dd2cea35
Update version number for the 9.7.2 release 2024-06-01 14:49:45 +02:00
Ihor Radchenko 5b8159228a
etc/ORG-NEWS: Move user-facing changes near the top 2024-06-01 14:49:18 +02:00
Ihor Radchenko 0ea4dc166c
org-html-latex-environment: Fix error when environment is non-math
* lisp/ox-html.el (org-html-latex-environment): Do not try to compute
caption for non-math environments.
2024-06-01 14:47:43 +02:00
Ihor Radchenko f737e7213d
Update version number for the 9.7.1 release 2024-06-01 11:14:24 +02:00
Ihor Radchenko 9189ccacd5
etc/ORG-NEWS: Remove "unreleased" from Version 9.7 2024-06-01 11:12:30 +02:00
Ihor Radchenko 5fe70f2d66
Update version number for the 9.7 release 2024-06-01 10:59:57 +02:00
Ihor Radchenko eec8ba4087
Merge branch 'bugfix' 2024-06-01 10:58:39 +02:00
Ihor Radchenko dc485a6590
lisp/org-persist.el: Ignore lock files when writing cache
* lisp/org-persist.el (org-persist--write-elisp-file): Ignore locks.

Reported-by: Greg Minshall <minshall@umich.edu>
Link: https://orgmode.org/list/574109.1715751441@archlinux
2024-05-30 15:31:20 +02:00
Kyle Meyer 64bb80b982 Update customize-package-emacs-version-alist
* lisp/org.el (customize-package-emacs-version-alist): Map Org 9.7 to
Emacs 30.1.
2024-05-28 23:43:46 -04:00
Kyle Meyer 53c39a494f org-ctags: Don't assume ctags-program-name is bound
* lisp/org-ctags.el (org-ctags-path-to-ctags): Fall back to "ctags" if
ctags-program-name isn't bound because that wasn't introduced until
Emacs 30.

This is a follow-up commit to the port of Emacs's 9082b4e6e.
2024-05-28 23:23:39 -04:00
Kyle Meyer 377addb5b2 Merge branch 'km/from-emacs-master' 2024-05-28 23:01:23 -04:00
Tim Landscheidt d12f8b8624 Backport commit 6d1c1fca0 from Emacs
* lisp/ob-calc.el: (org-babel-execute:calc):
* lisp/org-agenda.el (org-agenda-use-sticky-p):
Replace (with-current-buffer (get-buffer ...) ...) with
(with-current-buffer ...).

; Simplify (with-current-buffer (get-buffer ...) ...)
6d1c1fca0aa7c5a1ff0254af3f89a34d5309ea0d
Tim Landscheidt
Thu Mar 14 12:40:26 2024 +0200
2024-05-28 22:58:43 -04:00
Basil L. Contovounesios 014f85f55f Backport commit 6dacb60bb from Emacs
; Fix last major-mode-remap-defaults change.
6dacb60bb135dbb002c2ce1c70f70430c5d1bbff
Basil L. Contovounesios
Mon Mar 4 07:19:22 2024 +0100
2024-05-28 22:58:43 -04:00
Stefan Monnier ab62bdd79f Backport commit 2b5d43081 from Emacs
* lisp/ox.el (org-export-to-buffer): Modernize docstring accordingly.
* lisp/ox-latex.el (org-latex-export-as-latex):
* lisp/ox-koma-letter.el (org-koma-letter-export-as-latex):
* lisp/ox-beamer.el (org-beamer-export-as-latex):
Use `major-mode-remap` when available.

(major-mode-remap(-defaults)): New var and function (bug#69191)
2b5d43081a30f816dd38a16c7b5bfbad712a779b
Stefan Monnier
Sun Mar 3 23:58:18 2024 -0500
2024-05-28 22:58:43 -04:00
Stefan Monnier e8fe9642b0 Backport commit 445f376e4 from Emacs
Revert "ox-texinfo:: Require only TEXINFO_DIR_CATEGORY"
445f376e4e613ebee94d2844926269bfa8793858
Stefan Monnier
Sun Mar 3 22:09:24 2024 -0500
2024-05-28 22:58:43 -04:00
Stefan Monnier 5dc2b6ee75 Backport commit 1a37fe3a6 from Emacs
Revert "Set org-macro-templates more lazily"
1a37fe3a66930bb8151a29c722dbe3bebc20d033
Stefan Monnier
Sun Mar 3 22:09:19 2024 -0500
2024-05-28 22:58:43 -04:00
Stefan Monnier fb4d2b96dc Backport commit 99483e214 from Emacs
Set org-macro-templates more lazily
99483e214fdafa76e8001c7009dff13a76c33f32
Stefan Monnier
Sun Mar 3 16:57:56 2024 -0500
2024-05-28 22:58:43 -04:00
Stefan Monnier 338ff105c5 Backport commit 5254c582e from Emacs
* lisp/ox-texinfo.el: Remove redundant `:group` arguments.
Prefer #' to quote function names.
(org-texinfo-template): Use sane defaults for `@direntry`.

* doc/org.org (Texinfo specific export settings): Adjust accordingly.

ox-texinfo:: Require only TEXINFO_DIR_CATEGORY
5254c582efb3e7171e955dde653e7530d2d3ffef
Stefan Monnier
Sun Mar 3 16:57:56 2024 -0500
2024-05-28 22:58:43 -04:00
Robert Pluim 5a176d76ad Backport commit 862dfef88 from Emacs
* lisp/org-macs.el (org-split-string): Escape control chars.
* lisp/ox-latex.el (org-latex-guess-babel-language): And here.

Pacify more docstring control char warnings
862dfef88d8e62d12bac3ca2e44e035a2ff5b298
Robert Pluim
Thu Feb 29 09:31:41 2024 +0100
2024-05-28 22:58:43 -04:00
Stefan Kangas 6c34fd374c Backport commit 9364c2895 from Emacs
; Fix typos in symbol names
9364c28959a5b00e8ffd5d0d283ff0c0042f1bb0
Stefan Kangas
Sun Jan 21 15:28:06 2024 +0100
2024-05-28 22:58:43 -04:00
Stefan Kangas 7564dfd968 Backport commit 0f3be9596 from Emacs
; Prefer finder keyword "text" to deprecated keyword "wp"
0f3be9596fb3cf2f5e8f10fe2b3ef59546de98bb
Stefan Kangas
Sat Dec 30 18:14:40 2023 +0100
2024-05-28 22:58:43 -04:00
Stefan Monnier 68f9abe0cd Backport commit 40dafa9af from Emacs
* lisp/org-src.el (org-src-font-lock-fontify-block): Fix point-min /= 1
40dafa9af0ae3b1826409ebed80cb65f56591ffb
Stefan Monnier
Wed Dec 20 17:50:09 2023 -0500
2024-05-28 22:58:43 -04:00
Mattias Engdegård 1bff87bdb7 Backport commit 67977ae59 from Emacs
* lisp/org/org.el (org-make-tags-matcher):
Apply the transform (A+B*)+ -> A(A|B)*

Eliminate some nested repetitions in regexps
67977ae5974e54d34034aa7990cf22dd162c179b
Mattias Engdegård
Sun Oct 29 17:40:36 2023 +0100
2024-05-28 22:58:43 -04:00
Stefan Kangas 5e9a60aaae Backport commit 2e19e1163 from Emacs
* lisp/ob-lua.el (org-babel-lua-evaluate-session):
* lisp/ob-python.el (org-babel-python-initiate-session-by-key):
(org-babel-python-evaluate-session): Don't use obsolete 'sleep-for'
argument.
2024-05-28 22:58:43 -04:00
Stefan Kangas 53d3fcfbe9 Backport commit 6b2219cd2 from Emacs
* lisp/org.el (org-read-date-analyze):
* lisp/ox-html.el (org-html-latex-fragment):
Add several "duplicate value in `cond`" FIXMEs.
Found by Mattias Engdegård <mattias.engdegard@gmail.com>.
Ref: https://debbugs.gnu.org/51368#51

; Add several "duplicate value in `cond`" FIXMEs
6b2219cd2744c711580cc7226554e69c8cec8247
Stefan Kangas
Sun Oct 1 19:00:26 2023 +0200
2024-05-28 22:58:43 -04:00
Stefan Kangas d7ee5691cb Backport commit e0070fc57 from Emacs
* lisp/ob-eshell.el (org-babel-execute:eshell): Improve docstring.

Improve org-babel-execute:eshell docstring
e0070fc574a8621b2fbb1aaca678b974a3dc5fd5
Stefan Kangas
Sun Sep 17 16:57:25 2023 +0200
2024-05-28 22:58:43 -04:00
Stefan Kangas c49b8f68ca Backport commit 1e270e580 from Emacs
; Grammar fixes ("allow to" et al)
1e270e580d3bb9ca1b3766a296611f76ec13f6f1
Stefan Kangas
Sun Sep 17 16:49:21 2023 +0200
2024-05-28 22:58:43 -04:00
Stefan Monnier b2b9a96192 Backport commit ff87aecf8 from Emacs
* lisp/org.el: Remove dead-code.

Address "Useless clause following default cond clause" warnings
ff87aecf8554042b043467a7aaff1a758df0bbae
Stefan Monnier
Tue Sep 12 12:59:03 2023 -0400
2024-05-28 22:58:43 -04:00
Po Lu 88ac4758a7 Backport commit c0400151f from Emacs
* lisp/org.el (org-startup-truncated, org-file-apps):
The construct ``allows to <infinitive>'' is not English inasmuch as no
direct object to ``allows'' is provided.  Correct and rephrase each
instance of such a construct within our documentation and commentary.

Correct many instances of ``allows to''
c0400151f8880862d460f0e47be287237a6182ad
Po Lu
Sun Sep 10 09:33:50 2023 +0800
2024-05-28 22:58:43 -04:00
Stefan Kangas 0e345ecda8 Backport commit 642691251 from Emacs
; Delete redundant defvars; font-lock is preloaded
64269125156836060eb95b28b01b877c74e800d8
Stefan Kangas
Fri Aug 25 23:54:51 2023 +0200
2024-05-28 22:58:43 -04:00
Stefan Kangas bb7473f3d3 Backport commit 2b311a47d from Emacs
* lisp/ox-beamer.el (org-mode): Assume that font-lock is preloaded,
which it has been since Emacs 22.1.

Assume that font-lock is preloaded
2b311a47dd0cde82fb9d32c303f13700cae4f0b3
Stefan Kangas
Fri Aug 25 20:35:38 2023 +0200
2024-05-28 22:58:43 -04:00
Po Lu 860d4fd169 Backport commit 73b24a414 from Emacs
* lisp/org-mouse.el (org-mouse-down-mouse): Characterize as an
`ignored-mouse-command'.

Make org-mouse compatible with touch screen event emulation
73b24a41412eb97a9451a8310da0ebab379f7534
Po Lu
Wed Aug 23 09:56:35 2023 +0800
2024-05-28 22:58:43 -04:00